Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: store and forward chronology #4166

Open
jranma opened this issue Jun 23, 2024 · 5 comments
Open

[Bug]: store and forward chronology #4166

jranma opened this issue Jun 23, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@jranma
Copy link

jranma commented Jun 23, 2024

Category

Other

Hardware

T-Beam S3

Firmware Version

2.3.12

Description

when one retrieves store and forward messages using "SF", all messages will arrive at the same time. Above all, they will all be displayed with the time they were retrieved, not the time they were received on the relay. It is therefore difficult, if not impossible, to understand the thread of the conversation because the chronologies are wrong.

Relevant log output

No response

@jranma jranma added the bug Something isn't working label Jun 23, 2024
@garthvh
Copy link
Member

garthvh commented Jun 28, 2024

Where are you seeing the messages with the same time?

@jranma
Copy link
Author

jranma commented Jun 30, 2024

each time I request messages with a "SF" command, I get all the messages with the same time, which is the time at wich I requested them.
Using Android APP.

@GUVWAF
Copy link
Member

GUVWAF commented Jun 30, 2024

Yes, that sounds correct. Currently the timestamp when the packet was actually received is not stored and send with the packet upon request.

@jranma
Copy link
Author

jranma commented Jun 30, 2024

OK, not sure the messages come in the right order.
Last time I received many messages and as the timestamp are all the same, I had a hard time understanding the logic of the conversation.
Having the message sorted by their "real" timestamp would be a nice emprovement.

@GUVWAF GUVWAF self-assigned this Jul 7, 2024
@GUVWAF
Copy link
Member

GUVWAF commented Jul 7, 2024

I think we can make this work. Currently we do store a relative time in the StoreForward history, but we can change it to an absolute time if we have one, and then not updating the rx_time for StoreForward packets when requesting them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants