-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"macOS-universal.zip" is double-compressed #2232
Comments
Probably a mistake with the zipping in the GitHub Actions job. It seems like Finder just double-unzips it for you without making you aware anything is weird so I never noticed this. |
i can confirm it is not a problem in the Finder |
Turns out there was actually a reason I did it like that. The automatic zipping that GitHub Actions does doesn't preserve file attributes. That breaks the app bundle because the executable needs to be marked as executable. For the actual 1.0 release we should make sure to not upload it double-zipped though... |
thats weird because so many projects are using GitHub Actions for their macOS binaries without issues...hmmm |
when unzipping macOS-universal.zip this just contains another similarly named zip file. the app is only inside the zip file contained in the first zip. why?
The text was updated successfully, but these errors were encountered: