Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"macOS-universal.zip" is double-compressed #2232

Open
core-code opened this issue Dec 11, 2024 · 4 comments
Open

"macOS-universal.zip" is double-compressed #2232

core-code opened this issue Dec 11, 2024 · 4 comments

Comments

@core-code
Copy link

when unzipping macOS-universal.zip this just contains another similarly named zip file. the app is only inside the zip file contained in the first zip. why?

@nadiaholmquist
Copy link
Collaborator

Probably a mistake with the zipping in the GitHub Actions job. It seems like Finder just double-unzips it for you without making you aware anything is weird so I never noticed this.

@core-code
Copy link
Author

i can confirm it is not a problem in the Finder

@nadiaholmquist
Copy link
Collaborator

nadiaholmquist commented Dec 11, 2024

Turns out there was actually a reason I did it like that. The automatic zipping that GitHub Actions does doesn't preserve file attributes. That breaks the app bundle because the executable needs to be marked as executable.

For the actual 1.0 release we should make sure to not upload it double-zipped though...

@core-code
Copy link
Author

thats weird because so many projects are using GitHub Actions for their macOS binaries without issues...hmmm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants