Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI tests should run automatically on latest release or pre-release of MeiliSearch #184

Open
mdubus opened this issue Nov 15, 2021 · 1 comment
Labels
maintenance Issue about maintenance (CI, tests, refacto...)

Comments

@mdubus
Copy link
Member

mdubus commented Nov 15, 2021

For the moment, in tests.yml I have hard-coded the version of MeiliSearch, on which to launch the tests.

 services:
      meilisearch:
        image: getmeili/meilisearch:v0.24.0rc2
        env:
          MEILI_MASTER_KEY: 'masterKey'
          MEILI_NO_ANALYTICS: 'true'
        ports:
          - '7700:7700'

This means that on every release, or pre-release I have to manually update the version.
We should find a way to automate the version update.

@bidoubiwa
Copy link
Contributor

There are two possibilities to run a specific version of meilisearch.

Either through the latest rc script, for example in meilisearch-js

Either through the normal docker service as per example in meilisearch-js

The way it works in these repositories is that, based on the branch naming, it will either run the tests of the latest release or the latest rc.
To implement this, you just need to create a second workflow file, but this one would use the latest rc script and trigger based on a branch naming.

Or, you consider that testing against the rc's is enough in which case just change the way you trigger Meilisearch with this example

@bidoubiwa bidoubiwa added enhancement New feature or request maintenance Issue about maintenance (CI, tests, refacto...) and removed enhancement New feature or request labels Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue about maintenance (CI, tests, refacto...)
Projects
None yet
Development

No branches or pull requests

2 participants