Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API for 2D UNeXt2 model construction needs clarity #107

Open
mattersoflight opened this issue Jul 9, 2024 · 2 comments
Open

API for 2D UNeXt2 model construction needs clarity #107

mattersoflight opened this issue Jul 9, 2024 · 2 comments
Assignees

Comments

@mattersoflight
Copy link
Member

mattersoflight commented Jul 9, 2024

The DL@MBL exercise (#100) uses the following call to create a 2D UNeXt2 model.

phase2fluor_model = VSUNet(
    architecture='fcmae', #2D UNeXt2 architecture
...

The above can mislead users into thinking they are working with a masked autoencoder.

@ziw-liu does this also affect #70 ? Can you please fix this while merging #100?

@ziw-liu
Copy link
Collaborator

ziw-liu commented Jul 10, 2024

does this also affect #70

I think #70 used a 3D version of UNeXt2.

@edyoshikun
Copy link
Contributor

edyoshikun commented Jul 10, 2024

From the discussion with @ziw-liu, we will move forward by adding temporarily
UNeXt2_2D as an alias to fcmae for the 0.2.0 release. Merging the architectures right now is not feasible if we want to load the weights provided in the releases.

After the release, we will merge UNeXt2 and fcmae architectures most likely by deprecating UNeXt2 and adding the missing arguments to fcmae.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants