Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnBlur event improvement #37

Open
Diizer opened this issue Jan 11, 2019 · 3 comments
Open

OnBlur event improvement #37

Diizer opened this issue Jan 11, 2019 · 3 comments

Comments

@Diizer
Copy link

Diizer commented Jan 11, 2019

Hi, your credit card solution for react very nice!

It would be awesome, if OnBlur event, for each inputs, would shows us an invalid state.
Also if input is invalid, error notification shoud not disapear.
Now If you fill card number (with invalid card), then fill CVC input - there is no error message for invalid card.

For example, if I'd like to disable submit button, if at least one input are invalid.

Now its looks like -
image

And if invalid card, no error after filling CVC and OnBlur
image

@jxom
Copy link
Contributor

jxom commented May 21, 2019

I am currently finishing up a new package for using payment inputs with React, which I hope to publish soon!

The new package will handle error event handling much better.

If you're interested, I'm planning to add a migration guide to migrate from react-credit-card-input to the new package - don't worry, it will be a small migration.

I'll comment here again once it's published. :)

@Diizer
Copy link
Author

Diizer commented May 21, 2019

Hi, Jake
Sounds great!
Btw, I'm still waiting for resolving this issue. If you have a better package that would be nice, I'll definitely use it )

@jxom
Copy link
Contributor

jxom commented May 26, 2019

We have just recently published a new library, React Payment Inputs which is a rewrite of react-credit-card-input, and fixes a lot of issues that were raised in this repository as well as a few extra enhancements.

Your issue that you raised here should be fixed in React Payment Inputs - however, if you wish to still use react-credit-card-inputs, I'll try find time to fix this issue in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants