Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research Spike: ESLint 9 compatibility #477

Open
4 tasks done
ChristianMurphy opened this issue Oct 5, 2023 · 7 comments
Open
4 tasks done

Research Spike: ESLint 9 compatibility #477

ChristianMurphy opened this issue Oct 5, 2023 · 7 comments

Comments

@ChristianMurphy
Copy link
Member

Initial checklist

Problem

ESLint 9 is changing the plugin API: https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/
There may be changes needed in ESLint-MDX

Solution

Check to see if any changed/removed APIs are used, migrate if needed.

Alternatives

  • No change may be needed
  • We could remain on eslint 8 for a while if the migration is challenging
@JounQin
Copy link
Member

JounQin commented Dec 5, 2023

image

I don't see how to test eslint@9 at this point.

@ChristianMurphy
Copy link
Member Author

@remcohaszing
Copy link
Member

Since the new flat config no longer resolves files, and supports eslint.config.mjs, I think ESLint MDX integrations can switch to ESM.

@JounQin
Copy link
Member

JounQin commented Dec 30, 2023

Since the new flat config no longer resolves files, and supports eslint.config.mjs, I think ESLint MDX integrations can switch to ESM.

I'd like to keep dual. Legacy .eslintrc configs are still supported.

@ChristianMurphy
Copy link
Member Author

Legacy configuration are deprecated https://eslint.org/blog/2023/12/eslint-v9.0.0-alpha.0-released/

There are far less quirks and hacks packaging as pure ESM, rather than dealing with dual packaging limitations.

@JounQin
Copy link
Member

JounQin commented Dec 30, 2023

#496

@ChristianMurphy

worker.mts will bypass all the limitations.

They're deprecated but still supported. I don't want to break anyone's current workflow before they're ready including myself.

For example, compatibility with other plugins.

import-js/eslint-plugin-import#2948 (comment)

@tianyingchun
Copy link

What's the plan?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants