Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Image delete toolbar button should be disabled when editor is in read only mode (similar to imageEditToolbar) #475

Closed
ajboni opened this issue Jun 2, 2024 · 0 comments · Fixed by #534
Closed

[BUG] Image delete toolbar button should be disabled when editor is in read only mode (similar to imageEditToolbar) #475

ajboni opened this issue Jun 2, 2024 · 0 comments · Fixed by #534
Labels
bug Something isn't working

Comments

@ajboni
Copy link

ajboni commented Jun 2, 2024

relevant line :

editor/src/plugins/image/ImageEditor.tsx

Line 275 in a9848a7

<button

when setting the editor as readonly, the editImageButton button get s an additional disabled property . However the "Delete Image" button does not change.

image
@ajboni ajboni added the bug Something isn't working label Jun 2, 2024
@Fir121 Fir121 mentioned this issue Jul 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added disabled property in image delete button Fir121/editor
1 participant
@ajboni