Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctests fail on some architectures (i686, s390x) #3

Open
blinxen opened this issue Oct 6, 2023 · 2 comments
Open

Doctests fail on some architectures (i686, s390x) #3

blinxen opened this issue Oct 6, 2023 · 2 comments

Comments

@blinxen
Copy link

blinxen commented Oct 6, 2023

I am packaging byteyarn for Fedora because it is a dependency of gitoxide. When running doctests on i686 and s390x machines, most doctests fail. See:

There are assertion fails:

assertion `left == right` failed
  left: 3242591731706757321
 right: 9

But more importantly there are tests that just straight up crash with a Test executable failed (signal: 11 (SIGSEGV) (core dumped)).

Looking at the code (e.g. this function), it appears that the you assume the byte order. This however cannot work if the byte order is reversed (little endian vs big endian).

@Byron
Copy link

Byron commented Oct 6, 2023

Maybe these targets could also be tested on CI to prevent future regression.

@mcy
Copy link
Owner

mcy commented Dec 27, 2023

This looks like 32-bit support doesn't work quite right. I do not have a way to test 32-bit support, so I can't fix it without someone providing that. I would like to support 32-bit correctly, though.

I do not care at all for big-endian. If someone writes a patch and provides me a way to keep it not-broken in CI, I would be ok with that. I would also be OK with a patch that turns RawYarn into a thin wrapper over Box<[u8]> in BE mode. I doubt anyone will care about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants