Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering Footnotes #24

Closed
stoweboyd opened this issue Aug 22, 2022 · 10 comments
Closed

Rendering Footnotes #24

stoweboyd opened this issue Aug 22, 2022 · 10 comments
Labels

Comments

@stoweboyd
Copy link

It would be good if footnotes were rendered in the copied file.

In my use case, I write comments and place tags and other annotations in footnotes, but for sharing with others those would be better at the foot of the rendered file.

@mcndt
Copy link
Owner

mcndt commented Aug 22, 2022

I agree, footnotes should be rendered correctly. I'll mark it as a future feature. Stay tuned!

@mcndt mcndt added the feature label Aug 22, 2022
@mcndt mcndt transferred this issue from mcndt/obsidian-quickshare Aug 22, 2022
@mcndt mcndt moved this to Todo in Noteshare.space Aug 22, 2022
@mcndt
Copy link
Owner

mcndt commented Aug 23, 2022

for future reference, a good starting point: markedjs/marked#1562 (comment)

@mcndt
Copy link
Owner

mcndt commented Aug 23, 2022

Works now!

@mcndt mcndt closed this as completed Aug 23, 2022
@mcndt mcndt moved this from Todo to Shipped in Noteshare.space Aug 23, 2022
@stoweboyd
Copy link
Author

stoweboyd commented Aug 23, 2022

@mcndt
Copy link
Owner

mcndt commented Sep 9, 2022

So sorry for my late response, I have been traveling.

I am unfamiliar with this footnote syntax. Is it a way to define the footnote text inline? I was previously only familiar with this syntax:

This is a paragraph^[1].

[1]: This is the footnote text, which will be rendered at the bottom of the page.

@mcndt mcndt reopened this Sep 9, 2022
@mcndt mcndt moved this from Shipped to In Progress in Noteshare.space Sep 9, 2022
@stoweboyd
Copy link
Author

stoweboyd commented Sep 10, 2022 via email

@mcndt
Copy link
Owner

mcndt commented Sep 11, 2022

I created a new issue to track this bug separately, see #31.

@mcndt mcndt closed this as completed Sep 11, 2022
@mcndt mcndt moved this from In Progress to Shipped in Noteshare.space Sep 11, 2022
@stoweboyd
Copy link
Author

stoweboyd commented Sep 11, 2022 via email

@mcndt
Copy link
Owner

mcndt commented Sep 11, 2022

As I said, I created a new issue to track the bug. I haven't fixed it just yet :) But don't worry, it's on my radar.

You can subscribe to the new thread to follow progress: #31

@stoweboyd
Copy link
Author

stoweboyd commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Shipped
Development

No branches or pull requests

2 participants