Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a non-US Culture may cause errors! #11

Open
Andis59 opened this issue Sep 2, 2019 · 0 comments
Open

Using a non-US Culture may cause errors! #11

Andis59 opened this issue Sep 2, 2019 · 0 comments

Comments

@Andis59
Copy link

Andis59 commented Sep 2, 2019

I'm Swedish and using Culture sv-SE, One of the things that this does is changing the decimal separator to a comma (,)

This leads to a lot of problem for all places that uses double.ToString or String Interpolation, e.g.

frequency = double.Parse(frequencyMatch.Groups[0].ToString());
qualifier =$"/{DefaultNoteSettings.DefaultDuration}"

They should (may) be changed to

frequency = double.Parse(frequencyMatch.Groups[0].ToString(), CultureInfo.InvariantCulture);
qualifier = FormattableString.Invariant($"/{DefaultNoteSettings.DefaultDuration}");
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant