Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CI pipelines the same across projects #13

Closed
2 tasks
stevenbal opened this issue Apr 12, 2024 · 4 comments · Fixed by maykinmedia/objecttypes-api#129 · 4 remaining pull requests
Closed
2 tasks

Make CI pipelines the same across projects #13

stevenbal opened this issue Apr 12, 2024 · 4 comments · Fixed by maykinmedia/objecttypes-api#129 · 4 remaining pull requests
Assignees
Labels
enhancement New feature or request owner: maykin

Comments

@stevenbal
Copy link
Contributor

stevenbal commented Apr 12, 2024

Not sure if this repo is the right place for this issue, but I noticed that Open Zaak has an image_scan job in the CI pipeline: https://github.com/open-zaak/open-zaak/blob/main/.github/workflows/ci.yml#L268. Is this something we want in the other projects as well?

In general, I think it is a good idea to check if the pipelines are the same (or at least as close as possible) and up to date when it comes to versions for actions

  • Add the best things to the default project - api folder.
  • Make sure all the API projects have similar CI pipelines
@stevenbal stevenbal added the triage Triage means the team has not yet refined this issue. label Apr 12, 2024
@stevenbal
Copy link
Contributor Author

Maybe we could make use of https://github.com/maykinmedia/setup-django-backend/tree/v1.3

@joeribekker joeribekker added enhancement New feature or request owner: maykin and removed triage Triage means the team has not yet refined this issue. labels Jun 18, 2024
@SonnyBA SonnyBA added the triage Triage means the team has not yet refined this issue. label Jul 30, 2024
@joeribekker joeribekker removed the triage Triage means the team has not yet refined this issue. label Jul 30, 2024
@SonnyBA
Copy link
Contributor

SonnyBA commented Aug 6, 2024

A first effort to make the CI pipelines more consistent was made through open-zaak/#1730. The code quality workflow was used for this and now reuses the code quality workflow from the open-api-workflows repository.

@SonnyBA SonnyBA added the triage Triage means the team has not yet refined this issue. label Aug 6, 2024
@SonnyBA
Copy link
Contributor

SonnyBA commented Aug 6, 2024

Moving the workflow files to the root repository does not seem possible (screenshot taken from an open-zaak run):

Image

@SonnyBA SonnyBA removed the triage Triage means the team has not yet refined this issue. label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment