Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create destruction list page (Record manager) [backend] #340

Assignees

Comments

@SilviaAmAm
Copy link
Collaborator

SilviaAmAm commented Apr 29, 2024

  • GET /zaken: Endpoint to retrieve zaken open-archiefbeheer#2

    Only logged in users can access. Should it be limited to a specific role?

    Paginated response.

    It should be possible to filter on all the fields of the zaak. However, OZ only supports limited filters (See OZ: /zaken/api/v1/schema/#tag/zaken/operation/zaak_list). Other filters should be taken care of by the frontend?

    Should zaken already included in a destruction list be filtered out? Do we want them displayed but disabled?

  • Auth endpoint: Authentication endpoints open-archiefbeheer#1

    For the users to log in.

  • GET /reviewers Endpoint to retrieve reviewers open-archiefbeheer#4

    Get all the possible users that are available to review a list. In the previous version, by default all lists had 2 reviewers and it was not possible to change the number of reviewers.
    However, a feature was later added that if a list contained zaken with a single zaaktype and this zaaktype was on a (configured) list of zaaktypen with 'speedy review process', then the destruction list would require only one reviewer.
    There were later requests for making the number of reviewers configurable.
    How do we want to approach this here?

  • POST /destruction-list Add endpoint for list creation open-archiefbeheer#5

    Create the destruction list, with associated zaken and reviewers. Should validate that the zaken are not included in other destruction lists.

    Question: in the designs, the modal contains a 'periode' field. What is this?

    This kicks off the review process. The first reviewer receives a review-request per email.

@SilviaAmAm SilviaAmAm self-assigned this Apr 29, 2024
@svenvandescheur
Copy link
Contributor

svenvandescheur commented Apr 30, 2024

It should be possible to filter on all the fields of the zaak. However, OZ only supports limited filters (See OZ: /zaken/api/v1/schema/#tag/zaken/operation/zaak_list). Other filters should be taken care of by the frontend?

Discussed with @joeribekker , we have green light to introduce experimental features to OZ within limits. An additional query param filter should be doable if we adhere to the correct developer flow. Please discuss with @joeribekker (how to introduce) the changes required.

Should zaken already included in a destruction list be filtered out? Do we want them displayed but disabled?

These should not be shown.

Question: in the designs, the modal contains a 'periode' field. What is this?

This field can be left out as it can be resolved using the linked cases. The type of list (Archiefnominatie) is missing in the design and should be shown. "Bewaren" (keep) or "Vernietigen" (destroy). OZ should support this and previously this was selected on a per case level.

@svenvandescheur svenvandescheur changed the title Create destruction list page (Record manager) Create destruction list page (Record manager) [backend] Apr 30, 2024
@svenvandescheur
Copy link
Contributor

svenvandescheur commented Apr 30, 2024

SilviaAmAm added a commit to maykinmedia/open-archiefbeheer that referenced this issue May 1, 2024
SilviaAmAm added a commit to maykinmedia/open-archiefbeheer that referenced this issue May 1, 2024
@SilviaAmAm SilviaAmAm reopened this May 1, 2024
SilviaAmAm added a commit to maykinmedia/open-archiefbeheer that referenced this issue May 1, 2024
SilviaAmAm added a commit to maykinmedia/open-archiefbeheer that referenced this issue May 1, 2024
SilviaAmAm added a commit to maykinmedia/open-archiefbeheer that referenced this issue May 1, 2024
SilviaAmAm added a commit to maykinmedia/open-archiefbeheer that referenced this issue May 1, 2024
SilviaAmAm added a commit to maykinmedia/open-archiefbeheer that referenced this issue May 1, 2024
SilviaAmAm added a commit to maykinmedia/open-archiefbeheer that referenced this issue May 1, 2024
SilviaAmAm added a commit to maykinmedia/open-archiefbeheer that referenced this issue May 1, 2024
SilviaAmAm added a commit to maykinmedia/open-archiefbeheer that referenced this issue May 2, 2024
SilviaAmAm added a commit to maykinmedia/open-archiefbeheer that referenced this issue May 2, 2024
@SilviaAmAm SilviaAmAm reopened this May 2, 2024
SilviaAmAm added a commit to maykinmedia/open-archiefbeheer that referenced this issue May 2, 2024
SilviaAmAm added a commit to maykinmedia/open-archiefbeheer that referenced this issue May 2, 2024
SilviaAmAm added a commit to maykinmedia/open-archiefbeheer that referenced this issue May 2, 2024
SilviaAmAm added a commit to maykinmedia/open-archiefbeheer that referenced this issue May 2, 2024
SilviaAmAm added a commit to maykinmedia/open-archiefbeheer that referenced this issue May 2, 2024
SilviaAmAm added a commit to maykinmedia/open-archiefbeheer that referenced this issue May 2, 2024
SilviaAmAm added a commit to maykinmedia/open-archiefbeheer that referenced this issue May 2, 2024
SilviaAmAm added a commit to maykinmedia/open-archiefbeheer that referenced this issue May 2, 2024
SilviaAmAm added a commit to maykinmedia/open-archiefbeheer that referenced this issue May 2, 2024
SilviaAmAm added a commit to maykinmedia/open-archiefbeheer that referenced this issue May 2, 2024
SilviaAmAm added a commit to maykinmedia/open-archiefbeheer that referenced this issue May 2, 2024
SilviaAmAm added a commit to maykinmedia/open-archiefbeheer that referenced this issue May 3, 2024
SilviaAmAm added a commit to maykinmedia/open-archiefbeheer that referenced this issue May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment