Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mission module: Updated camera action commands (param4) to be compliant with mavlink standard #2118

Merged
merged 1 commit into from
Aug 20, 2023

Conversation

trolledbypro
Copy link
Contributor

@trolledbypro trolledbypro commented Aug 18, 2023

Hello,
As I continue to incorporate ArduPilot compatibility with MAVSDK Mission module (#2110), I noticed some discrepancies with how the camera action commands are formatted vs. the Mavlink standard for the commands. ArduPilot was rejecting the commands due to invalid parameters:

MAV_CMD_IMAGE_START_CAPTURE:
param 4 was set to NaN, must be set to 0 instead

MAV_CMD_VIDEO_START_CAPTURE
param 2 was set to NaN, must be set to 0 instead

In terms of testing, the only testing I have done in ArduPilot SITL is to see if the commands are accepted. These changes make both of these commands accepted. I have not tested in PX4 nor with real hardware.

… updated MAV_CMD_VIDEO_START_CAPTURE to be compliant as well
Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@julianoes julianoes merged commit 84eab2d into mavlink:main Aug 20, 2023
30 checks passed
@trolledbypro trolledbypro deleted the pr-mavlink-image-param-nan branch August 20, 2023 21:21
Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants