Mission module: Updated camera action commands (param4) to be compliant with mavlink standard #2118
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
As I continue to incorporate ArduPilot compatibility with MAVSDK Mission module (#2110), I noticed some discrepancies with how the camera action commands are formatted vs. the Mavlink standard for the commands. ArduPilot was rejecting the commands due to invalid parameters:
MAV_CMD_IMAGE_START_CAPTURE:
param 4 was set to NaN, must be set to 0 instead
MAV_CMD_VIDEO_START_CAPTURE
param 2 was set to NaN, must be set to 0 instead
In terms of testing, the only testing I have done in ArduPilot SITL is to see if the commands are accepted. These changes make both of these commands accepted. I have not tested in PX4 nor with real hardware.