Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replies to relayed messages have the wrong user in m.mentions #517

Open
pony1k opened this issue Jun 12, 2024 · 1 comment
Open

Replies to relayed messages have the wrong user in m.mentions #517

pony1k opened this issue Jun 12, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@pony1k
Copy link

pony1k commented Jun 12, 2024

Steps to repdroduce

  1. Have bridged room containing
    • a Matrix-only user (@bert:example.com)
    • a both Matrix and Signal user with relay enabled (@relay:example.com)
    • and a Signal-only user
  2. Matrix-only user writes a message
  3. Signal-only user replies to the relayed message
  4. Matrix-only user can not read the reply with element-android

Possible culprit
Take a look at the decrypted source of the puppets reply:

{
  "content": {
    "body": "some reply",
    "m.mentions": {
      "user_ids": [
        "@relay:example.com"
      ]
    },
    "m.relates_to": {
      "m.in_reply_to": {
        "event_id": "$event_1"
      }
    },
    "msgtype": "m.text"
  },
  "event_id": "$event_2",
  "origin_server_ts": 1718028861367,
  "room_id": "!xyz:example.com",
  "sender": "@signal_xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx:example.com",
  "type": "m.room.message",
  "unsigned": {}
}

Notice that the user id in m.mentions is @relay:example.com, which is the relaying user, not the one that is actually responsible for $event_1, which normally would be the case. Maybe this is a problem for some clients.

Additional info
It was also reported to me that element-android initially shows an error message, but I don't know yet what it sais. Also, users were able to read the reply message in a preview.

Version: 0.6.1+dev.860fad4d

@pony1k pony1k added the bug Something isn't working label Jun 12, 2024
@tulir
Copy link
Member

tulir commented Jun 12, 2024

Element Android doesn't support replies. However, bridged replies to relayed messages mentioning the wrong user seems like a real bug (it's not related to reply rendering in any way, just notifications)

@tulir tulir changed the title Signal-replies to relayed Matrix-messages are not displayed correctly in all Matrix-Clients Replies to relayed messages have the wrong user in m.mentions Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants