Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write documentation for Event Listeners component #215

Open
favour-chibueze opened this issue Sep 24, 2024 · 6 comments
Open

Write documentation for Event Listeners component #215

favour-chibueze opened this issue Sep 24, 2024 · 6 comments
Assignees
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@favour-chibueze
Copy link
Contributor

We need to write documentation on the Event Listeners component.

https://devdocs.mautic.org/en/5.x/plugins/event_listeners.html

@ifeoluwafavour
Copy link
Contributor

Hello @favour-chibueze
Please I would like to work on this issue
Are these the event listeners to be documented? https://github.com/mautic/mautic/tree/5.x/app%2Fbundles%2FPluginBundle%2FEventListener

@favour-chibueze
Copy link
Contributor Author

Sure.. see the old documentation too for the event listeners.

@ifeoluwafavour
Copy link
Contributor

Okay. Thank you!

@RCheesley RCheesley moved this from Ready to In progress in Mautic's 2024 No/Low/Code Tasks Oct 4, 2024
ifeoluwafavour added a commit to ifeoluwafavour/developer-documentation-new that referenced this issue Oct 7, 2024
Documentation for Event Listeners component mautic#215
@ifeoluwafavour
Copy link
Contributor

hello @favour-chibueze @RCheesley
I have created a pull request with the documentation for the Even Listeners component and it is ready for reviews because I'm not so sure about it 😅

@RCheesley
Copy link
Member

Fabulous @ifeoluwafavour thanks for doing that! I've done a review and made some suggested fixes for the grammar. Let's get that fixed first, then we can ask a core team member to do the technical review for accuracy.

@ifeoluwafavour
Copy link
Contributor

ifeoluwafavour commented Oct 9, 2024

Hello @RCheesley
Thank you for your kind words. I'm learning a lot!

I have applied the suggested changes. To accurately follow the external link syntax, I created a pull request to include Symfony's docs event subscribers link file to the link folder:
https://github.com/mautic/developer-documentation-new/pull/221/checks

P.S. I made this same comment yesterday thinking it was under this issue but it was under my pull request 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
Status: In progress
Development

No branches or pull requests

3 participants