-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deriveProof
does not support blank node identifiers for credentialSubject
#151
Comments
Current hypothesis is that is may be VC related by not LD Suite related... working to confirm that on the linked PR. |
Hmm, this test maybe covers this case https://github.com/mattrglobal/jsonld-signatures-bbs/blob/master/__tests__/AnonymousVC.spec.ts |
What's the suggested fix to this issue? Force the use of |
@tmarkovski that would be a suggested interim solution however the long term solution is a revision to the proof suite that accounts for this case in the URDNA algorithm. Given the recent consensus we have had around decentralized-identity/bbs-signature#10 I'm working on an updated implementation that incorporates this among various other changes |
Originally discovered by @brianorwhatever
See is reproduction here:
transmute-industries/verifiable-data#76
Surfacing from the linked PR description:
Related issues:
Questions:
deriveProof
on a credential with nocredentialSubject.id
? this example implies that it should be possible...The text was updated successfully, but these errors were encountered: