Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusion of zsh-completions submodule is unexpected #26

Closed
jeffqg opened this issue May 17, 2024 · 1 comment
Closed

Inclusion of zsh-completions submodule is unexpected #26

jeffqg opened this issue May 17, 2024 · 1 comment

Comments

@jeffqg
Copy link

jeffqg commented May 17, 2024

The zsh-users/zsh-completions plugin was added as a submodule in 6c62c8f. This runs counter to the FAQ from the README, "Why don't you also include popular plugins the way Prezto does (eg: zsh-autosuggestions, zsh-completions)?"

I don't know that this causes any problems, but it's a surprising discovery. IMO, the submodule should be removed from Zephyr and left to the user to pull in.

BTW, thanks for Zephyr and Antidote! My .zshrc is getting more understandable by the day.

@mattmc3
Copy link
Owner

mattmc3 commented Jul 15, 2024

You are correct. It's been removed.

@mattmc3 mattmc3 closed this as completed Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants