Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of minimumEventHeight in week view is incorrect #1666

Open
mkroeders opened this issue May 4, 2023 · 3 comments
Open

Documentation of minimumEventHeight in week view is incorrect #1666

mkroeders opened this issue May 4, 2023 · 3 comments

Comments

@mkroeders
Copy link

Describe the bug

The documentation of minimumEventHeight in the week view says it is the height in pixels. However it should be in minutes.

Or if it should be pixels than the getTimeEventResizedDates method uses it as minutes on line 1.348.

Minimal reproduction of the problem with instructions

When using it as pixels, when they are not the same as the minute size resizing goes wrong

Versions

angular calendar 0.31.0

@matts-bot
Copy link

matts-bot bot commented May 4, 2023

Thanks so much for opening an issue! If you'd like to support this project, then please consider sponsoring me

@billyjov
Copy link
Collaborator

billyjov commented Oct 5, 2023

@mkroeders can you pls provide a stackblitz reproduction of the issue?

@mkroeders
Copy link
Author

this.dateAdapter.addMinutes( newEventDates.end, this.minimumEventHeight * -1 )

@billyjov not sure how to stackblitz this. But if you look at line 1348 of CalendarWeekViewComponent you see it is used in a minute context. While the docs say it is in pixels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants