Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3 #19

Open
sethtroisi opened this issue Oct 16, 2019 · 1 comment
Open

python3 #19

sethtroisi opened this issue Oct 16, 2019 · 1 comment

Comments

@sethtroisi
Copy link
Contributor

Re-opening the discussion from #1, Python 2 is now dreadfully close to EOL.

  1. Would you be supportive of merging a port of the remaining code into sgfmill?
  2. Do you currently have time to review pull requests and explain any hair parts of the code?

I'm happy to take on the bulk of the work but it's nice to get confirmation that you'll have sometime to review and pull that code if I do the work. Also in the case that I get 90% of the code ported but some code remains outstanding would you be willing to pull it under a branch in sgfmill?

@mattheww
Copy link
Owner

Yes, I have time to help with this.

I think it would make more sense to make a Python 3 branch of gomill that has sgfmill as a requirement, rather than extending sgfmill.

My vague idea when I split out sgfmill was that the next step would be to split out the GTP code to a second library. That way it would be possible to do the conversion in pieces rather than all in one step.

But if you're willing to do the work, please organise things in whatever way is most convenient for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants