Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contract-verifier): Auto-verify the same bytecode #3309

Open
popzxc opened this issue Nov 20, 2024 · 0 comments
Open

feat(contract-verifier): Auto-verify the same bytecode #3309

popzxc opened this issue Nov 20, 2024 · 0 comments

Comments

@popzxc
Copy link
Member

popzxc commented Nov 20, 2024

Depends on #3190

We need to automatically verify the contracts with the same bytecode:

  • When a new contract is deployed, we should check if the verification data for this bytecode exists. If so, it shouldn't require additional verification.
  • When a new contract is verified, we should check if there are other contracts with the same bytecode. If so, they should become verified.
  • This should interact with partial matches: if there are differences in metadata, the contract should still be considered verified with partial match, but it should still be possible to do the "full" verification later.

⚠️ Don't treat the acceptance criteria as an implementation proposal: likely we don't actually need to scan the whole contracts table each time we deploy a contract or verify it. Most likely, we may just change the way we query verification data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant