Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foundryup overwrites foundry-zksync with base foundry #349

Open
PatrickAlphaC opened this issue Apr 26, 2024 · 3 comments
Open

foundryup overwrites foundry-zksync with base foundry #349

PatrickAlphaC opened this issue Apr 26, 2024 · 3 comments
Labels
p1 🟠 Indicates high priority item

Comments

@PatrickAlphaC
Copy link

Component

Forge

Describe the feature you would like

When I run foundryup to update my foundry edition, it removes my foundry-zksync installation.

Steps to reproduce:

  1. Install foundry-zksync (However you like)
  2. Run foundryup
  3. Try to do any foundry stuff with zksync, you cannot

Additional context

No response

@PatrickAlphaC PatrickAlphaC changed the title foundryup to update _this_ foundry foundryup overwrites foundry-zksync with base foundry Apr 26, 2024
@dutterbutter
Copy link
Collaborator

@PatrickAlphaC

Currently this is intentional as the installation uses the same base directory of .foundryup. If we want to avoid overwriting one another while also ensuring devs can execute the desired binary (between upstream and foundry-zksync) we would need to rename the binaries away from forge and cast. We want to keep the namespace the same, but perhaps we can introduce a forge version manager to switch between the two easily enough.

I will leave this open for now, but this is currently intentional.

@hensha256
Copy link

@dutterbutter I'm also facing this issue. After running foundryup i rebuilt zksync-foundry to try to get it to re-override forge and it wouldnt do so. I ended up using target/release/forge build --zksync to use this tool. Is this expected? If so I think it would be great to add it to the getting started docs somewhere!

@NouDaimon
Copy link

NouDaimon commented Aug 1, 2024

@dutterbutter The installation does not override when we set custom paths and aliases, but this adds a lot of overhead - both in installation and scripts for remote repos.

For engineers using both foundry and foundry-zksync this is cumbersome.

How much of an effort do you reckon it is to alter the base directory to .foundry-zksync and similarly renaming binaries by appending a -zkync?

This would make using the tools in such a way much more explicit.

I'm going to do manually set binary installation directory, and use aliases locally and explicitly define paths in scripts for collaborators but ideally this would be avoided.

@dutterbutter dutterbutter added the p1 🟠 Indicates high priority item label Oct 22, 2024
@dutterbutter dutterbutter pinned this issue Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 🟠 Indicates high priority item
Projects
None yet
Development

No branches or pull requests

4 participants