-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyboard navigation allows opening Filter, Sort and Group dropdowns simultaneously #4079
Comments
It seems that the underlying AttachableDropdown component uses a clickOffBounds action to close the dropdown when clicking outside of it (confirmed in the code below): mathesar/mathesar_ui/src/component-library/dropdown/AttachableDropdown.svelte Lines 130 to 133 in f157aed
However, this action does not handle focus-based events. A broader issue with dropdowns and keyboard navigation needs to be addressed first. Specifically, when a dropdown is triggered, focus should move to the first focusable child within the dropdown. Once that is in place, we can add logic to close the dropdown when focus shifts outside of it. @seancolsen or @pavish can likely confirm or clarify further. Once someone has confirmed my suspicions, I'll go ahead and create any necessary follow-up issues. Thanks for reporting this @sharath-1517! |
Similar: #1886 |
@zackkrida I am happy to contribute in any way I can to mathesar. It's my pleasure. |
Yes, I agree with your assessment here. Focus the first focusable element within the dropdown. Then don't allow focusing outside of it. We should do the same for modals. |
I've updated this issue to be blocked by #1886 and added more detail to that issue. |
Note
This issue is blocked by general accessibility improvements to the dropdowns, including:
Description
On the schemas page, when I tried to navigate the filters through the keyboard
using the Tab button
I noticed an unusual behavior of all three(Filters, Group, Sort)
opening at the same time when I pressedenter key
to open the focussed filter. I have attached a screenshot of this behavior. This is completely based on my opinion.Expected behavior
Only one of the three
(Filters, Group, Sort)
should open at a time.To Reproduce
The example in this link can be tried in the popup component.
Environment
Additional context
The text was updated successfully, but these errors were encountered: