Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On the table card menu, add an entry to open the Table Permissions modal #4070

Open
seancolsen opened this issue Dec 12, 2024 · 4 comments · May be fixed by #4082
Open

On the table card menu, add an entry to open the Table Permissions modal #4070

seancolsen opened this issue Dec 12, 2024 · 4 comments · May be fixed by #4082
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Milestone

Comments

@seancolsen
Copy link
Contributor

The Table Permissions modal is currently triggered via this button:

image

During user testing, I noticed that users might also expect to find it here:

image

We should add a menu entry there which opens the Table Permissions modal.

@seancolsen seancolsen added good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory labels Dec 12, 2024
@seancolsen seancolsen added this to the Backlog milestone Dec 12, 2024
@mathemancer
Copy link
Contributor

Yes please! I think I try that menu every single time I try to edit table permissions.

@sharath-1517
Copy link
Contributor

Hey @seancolsen I'd like to work on this issue.

@vishaljoshi789
Copy link
Contributor

Hi @seancolsen,
Here TablePermission is a component which takes table from the context, but when opening from menu there is no table in the context so,
Should I save the table on the context or,
Should I change the TablePermission component to take table as a prop.

@seancolsen
Copy link
Contributor Author

@vishaljoshi789 take table as a prop.

In TablePermissions.svelte I see:

const tabularData = getTabularDataStoreFromContext();

$: table = $tabularData.table;

We ought to be able to change that to

export let table: Table;

Then put a TablePermissions component inside each TableCard.

@vishaljoshi789 vishaljoshi789 linked a pull request Dec 16, 2024 that will close this issue
7 tasks
vishaljoshi789 added a commit to vishaljoshi789/mathesar that referenced this issue Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants