Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: ValueError in test_magnetic_orderings #1057

Open
janosh opened this issue Nov 14, 2024 · 7 comments
Open

BUG: ValueError in test_magnetic_orderings #1057

janosh opened this issue Nov 14, 2024 · 7 comments
Labels
bug Something isn't working magnetism Magnetism related testing Test all the things

Comments

@janosh
Copy link
Member

janosh commented Nov 14, 2024

@tpurcell90 i skipped the test_magnetic_orderings you added in #922 in this commit e7ac025. it started failing when upgrading to the latest pymatgen. i couldn't figure out why it started failing. if you have time, could you take a look?

@janosh janosh added bug Something isn't working testing Test all the things magnetism Magnetism related labels Nov 14, 2024
@tpurcell90
Copy link
Contributor

Yes I can do this today

@tpurcell90
Copy link
Contributor

I found the problem, it is in pymatgen. I will create a PR there and discuss with @ansobolev about the change.

@tpurcell90
Copy link
Contributor

@janosh The pymatgen fix was just merged in so this should now work

@janosh
Copy link
Member Author

janosh commented Dec 11, 2024

thanks for letting me know. we're still waiting on a new release, right?

@tpurcell90
Copy link
Contributor

Ya, I am not sure when the next pymatgen release will be, but it should work with the new one

@JaGeo
Copy link
Member

JaGeo commented Dec 11, 2024

@tpurcell90 You can always ask nicely on the repo for a release. Usually, the release follows quite fast. 🙂

@tpurcell90
Copy link
Contributor

Okay I asked about a new version in the PR for this fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working magnetism Magnetism related testing Test all the things
Projects
None yet
Development

No branches or pull requests

3 participants