-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: ValueError
in test_magnetic_orderings
#1057
Comments
Yes I can do this today |
I found the problem, it is in pymatgen. I will create a PR there and discuss with @ansobolev about the change. |
@janosh The pymatgen fix was just merged in so this should now work |
thanks for letting me know. we're still waiting on a new release, right? |
Ya, I am not sure when the next pymatgen release will be, but it should work with the new one |
@tpurcell90 You can always ask nicely on the repo for a release. Usually, the release follows quite fast. 🙂 |
Okay I asked about a new version in the PR for this fixed |
@tpurcell90 i skipped the
test_magnetic_orderings
you added in #922 in this commit e7ac025. it started failing when upgrading to the latestpymatgen
. i couldn't figure out why it started failing. if you have time, could you take a look?The text was updated successfully, but these errors were encountered: