Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete key doesn't open up end process dialogue when pressed on selected process [Feature Request] #101

Open
Yetoo1 opened this issue Oct 11, 2017 · 2 comments

Comments

@Yetoo1
Copy link

Yetoo1 commented Oct 11, 2017

Expected behaviour

Pressing the delete key should make the end process dialogue box appear.

Actual behaviour

Nothing happens at all when the delete key is pressed.

Steps to reproduce the behaviour

Press the delete key on a selected process.

MATE general version

1.18.0-1 Ubuntu

Package version

1.19.0 built from the master branch.

Linux Distribution

Ubuntu 17.10 Developmental release

gnome-system-manager has this feature yet this doesn't. I looked through the source code and I didn't find a single binding for the delete key. This would be convenient for those who are used to the keyboard short cut paradigm involving the delete key causing the deletion of a selection.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Yetoo1 Yetoo1 changed the title Delete key doesn't open up end process dialogue when pressed on selected process. (Suggestion) Delete key doesn't open up end process dialogue when pressed on selected process. Oct 11, 2017
@Yetoo1
Copy link
Author

Yetoo1 commented Oct 11, 2017

In case I gave actual valid reasons, I added the feature. I'm not sure how to add a patch with git so I'll just paste it here.

From 1198265841e2560f878341414c6019aa29a151d8 Mon Sep 17 00:00:00 2001
From: Yetoo1 <[email protected]>
Date: Wed, 11 Oct 2017 09:59:58 -0700
Subject: [PATCH] interface: Allows Delete key to kill processes

The delete key now can kill selected processes as Ctrl-K can while
the menu entry displaying the Ctrl+K shortcut remains. The purpose of
this is to allow convenience for those who are switching over from
gnome-system-monitor or other process managers which allow the
delete key to kill selected processes. This was accomplished by
adding an accelerator item with the delete key as the accelerator
and putting the menu entry of the KillProcess_Del on top of the
KillProcess menu entry so the latter shows over the former.

Issue #101
---
 src/interface.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/interface.cpp b/src/interface.cpp
index bacab98..3e41a62 100644
--- a/src/interface.cpp
+++ b/src/interface.cpp
@@ -66,6 +66,8 @@ static const GtkActionEntry menu_entries[] =
 
     { "EndProcess", NULL, N_("_End Process"), "<control>E",
       N_("Force process to finish normally"), G_CALLBACK (cb_end_process) },
+    { "KillProcess_Del", NULL, N_("_Kill Process"), "Delete",
+      N_("Force process to finish immediately"), G_CALLBACK (cb_kill_process) },
     { "KillProcess", NULL, N_("_Kill Process"), "<control>K",
       N_("Force process to finish immediately"), G_CALLBACK (cb_kill_process) },
     { "ChangePriority", NULL, N_("_Change Priority"), NULL,
@@ -137,6 +139,7 @@ static const char ui_info[] =
     "      <menuitem name=\"EditContProcessMenu\" action=\"ContProcess\" />"
     "      <separator />"
     "      <menuitem name=\"EditEndProcessMenu\" action=\"EndProcess\" />"
+    "      <menuitem name=\"EditKillProcessMenu\" action=\"KillProcess_Del\" />"
     "      <menuitem name=\"EditKillProcessMenu\" action=\"KillProcess\" />"
     "      <separator />"
     "      <menu name=\"EditChangePriorityMenu\" action=\"ChangePriority\" >"
@@ -175,6 +178,7 @@ static const char ui_info[] =
     "    <menuitem action=\"ContProcess\" />"
     "    <separator />"
     "    <menuitem action=\"EndProcess\" />"
+    "    <menuitem action=\"KillProcess_Del\" />"
     "    <menuitem action=\"KillProcess\" />"
     "    <separator />"
     "    <menu name=\"ChangePriorityMenu\" action=\"ChangePriority\" >"
@@ -835,6 +839,7 @@ update_sensitivity(ProcData *data)
     const char * const selected_actions[] = { "StopProcess",
                                               "ContProcess",
                                               "EndProcess",
+                                              "KillProcess_Del"
                                               "KillProcess",
                                               "ChangePriority",
                                               "MemoryMaps",
-- 
2.14.1

@Yetoo1 Yetoo1 changed the title Delete key doesn't open up end process dialogue when pressed on selected process. Delete key doesn't open up end process dialogue when pressed on selected process [Feature Request] Oct 11, 2017
@tylnesh
Copy link

tylnesh commented Feb 7, 2018

AFAIK, you should fork the repository, make the changes and submit a pull request. If you can't be bothered, I'll do it for you, as I'd like to see this feature added as well.

Yetoo1 added a commit to Yetoo1/mate-system-monitor that referenced this issue Apr 15, 2018
The delete key now can kill selected processes as Ctrl-K can while
the menu entry displaying the Ctrl+K shortcut remains. The purpose of
this is to allow convenience for those who are switching over from
gnome-system-monitor or other process managers which allow the
delete key to kill selected processes. This was accomplished by
adding an accelerator item with the delete key as the accelerator
and putting the menu entry of the KillProcess_Del on top of the
KillProcess menu entry so the latter shows over the former.

Issue mate-desktop#101
Yetoo1 added a commit to Yetoo1/mate-system-monitor that referenced this issue Apr 15, 2018
The delete key now can kill selected processes as Ctrl-K can while
the menu entry displaying the Ctrl+K shortcut remains. The purpose of
this is to allow convenience for those who are switching over from
gnome-system-monitor or other process managers which allow the
delete key to kill selected processes. This was accomplished by
adding an accelerator item with the delete key as the accelerator
and putting the menu entry of the KillProcess_Del on top of the
KillProcess menu entry so the latter shows over the former.

Issue mate-desktop#101

deleted a patch file

deleted a patch file
Yetoo1 added a commit to Yetoo1/mate-system-monitor that referenced this issue Apr 15, 2018
The delete key now can kill selected processes as Ctrl-K can while
the menu entry displaying the Ctrl+K shortcut remains. The purpose of
this is to allow convenience for those who are switching over from
gnome-system-monitor or other process managers which allow the
delete key to kill selected processes. This was accomplished by
adding an accelerator item with the delete key as the accelerator
and putting the menu entry of the KillProcess_Del on top of the
KillProcess menu entry so the latter shows over the former.

Issue mate-desktop#101
Yetoo1 added a commit to Yetoo1/mate-system-monitor that referenced this issue Jul 17, 2018
The delete key now can end selected processes as Ctrl-E can while
the menu entry displaying the Ctrl+E shortcut remains. The purpose of
this is to allow convenience for those who are switching over from
gnome-system-monitor or other process managers which allow the
delete key to End selected processes. This was accomplished by
adding an accelerator item with the delete key as the accelerator
and putting the menu entry of the EndProcess_Del on top of the
EndProcess menu entry so the latter shows over the former.

Issue mate-desktop#101
Yetoo1 added a commit to Yetoo1/mate-system-monitor that referenced this issue Jul 17, 2018
The delete key now can end selected processes as Ctrl-E can while
the menu entry displaying the Ctrl+E shortcut remains. The purpose of
this is to allow convenience for those who are switching over from
gnome-system-monitor or other process managers which allow the
delete key to End selected processes. This was accomplished by
adding an accelerator item with the delete key as the accelerator
and putting the menu entry of the EndProcess_Del on top of the
EndProcess menu entry so the latter shows over the former.

Issue mate-desktop#101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants