Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Add svt-av1 to the --photon-noise supported encoders #836

Open
Littux-Dustux opened this issue May 8, 2024 · 5 comments
Open

Comments

@Littux-Dustux
Copy link

The documentation currently states that --photon-noise is only supported by aom and rav1e, when it works fine with svt-av1 (Tested using svt-av1-psy)

    --photon-noise <PHOTON_NOISE>
        Generates a photon noise table and applies it using grain synthesis [strength: 0-64]
        (disabled by default)

        [...]

        This option currently only supports aomenc and rav1e.
@trixoniisama
Copy link

That would be because mainline SVT-AV1 has only merged the photon-noise patch very recently, even though we've had access to it for more than a year in Soichiro's fork initially, then BlueSwordM's fork with some other patches and in SVT-AV1-PSY then. It should indeed be changed.

0xBA5E64 added a commit to 0xBA5E64/Av1an that referenced this issue May 22, 2024
0xBA5E64 added a commit to 0xBA5E64/Av1an that referenced this issue May 22, 2024
@gitoss
Copy link

gitoss commented Jun 9, 2024

The commit is for the fix-docs branch only - is av1an photon noise working for svt-av1 by now because it added --fgs-table?

@shssoichiro
Copy link
Collaborator

Looks like I forgot to update the docs when I merged in the patch to av1an to support photon noise in svt-av1. It is indeed working, only the documentation needs updated.

@gitoss
Copy link

gitoss commented Jun 9, 2024

Looks like I forgot to update the docs when I merged in the patch to av1an to support photon noise in svt-av1. It is indeed working, only the documentation needs updated.

Thanks for the clarification.

Speaking of docs, the photon noise implementation is still a bit black-box-ish :-) and I am wondering what enabling av1an's --photon-noise does to the encoders' DE-noise settings - i.e. REEMOVING noise (svt --film-grain-denoise / aom --enable-dnl-denoising & --denoise-noise-level).

The --help of svt is especially unhelpful because the description for --film-grain-denoise only refers to --film-grain, but doesn't mention --fgs-table

Concerning adding noise, the doc 'the two should not be used together" is clear that photon and non-photon are mutually exclusive.

@shssoichiro
Copy link
Collaborator

Photon noise does not enable any of the encoder's denoising. You're right, it may make sense to add that to the documentation as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants