Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all TODOs from the test suite #339

Open
masak opened this issue May 18, 2021 · 1 comment
Open

Remove all TODOs from the test suite #339

masak opened this issue May 18, 2021 · 1 comment

Comments

@masak
Copy link
Owner

masak commented May 18, 2021

Current crop:

$ git grep -w TODO t
t/01-fn-read.t:!TODO: currently the printer doesn't handle "special" symbols
t/comfns.t:> "TODO (< \\a \\c) ==> t"
t/comfns.t:"TODO (< \\a \\c) ==> t"
t/comfns.t:> "TODO (< \\d \\b) ==> nil"
t/comfns.t:"TODO (< \\d \\b) ==> nil"
t/comfns.t:> "TODO (< \"aa\" \"ac\") ==> t"
t/comfns.t:"TODO (< \"aa\" \"ac\") ==> t"
t/comfns.t:> "TODO (< \"bc\" \"ab\") ==> nil"
t/comfns.t:"TODO (< \"bc\" \"ab\") ==> nil"
t/comfns.t:> "TODO (< 'aa 'ac) ==> t"
t/comfns.t:"TODO (< 'aa 'ac) ==> t"
t/comfns.t:> "TODO (< 'bc 'ab) ==> nil"
t/comfns.t:"TODO (< 'bc 'ab) ==> nil"
t/example-bel.t:> "TODO: (dedup:sort < \"abracadabra\") ==> \"abcdr\""
t/example-bel.t:"TODO: (dedup:sort < \"abracadabra\") ==> \"abcdr\""
t/fn-rdex.t:!TODO: currently the printer doesn't handle "special" symbols
t/mac-record.t:!TODO: The `pr` function does not yet respect `outs`

After fixing these TODOs, we could also remove the !TODO directive from L::B::Test::DSL.

@masak
Copy link
Owner Author

masak commented Oct 30, 2021

Seems we're down to three TODOs.

t/fn-rdex.t:!TODO: currently the printer doesn't handle "special" symbols
t/fn-read.t:!TODO: currently the printer doesn't handle "special" symbols
t/mac-record.t:!TODO: The `pr` function does not yet respect `outs`

These correspond to #266 and #253.

加油!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant