-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using a date format with day of the week causes app to crash #495
Comments
Also having this issue. Just installed today and running version It also makes the app unusable until I clear all storage related to it. |
@hplewis Would you mind installing F-droid and using the version from there? v1.10.2 is over a year old, I believe we might have fixed a bug related to this since then @theOperand |
I'm using v1.15.1, the latest version from F-Droid
…On 14/07/2020 03:06, robinpaulson wrote:
@hplewis <https://github.com/hplewis> Would you mind installing
F-droid and using the version from there? v1.10.1 is a few months old,
I believe we might have fixed a bug related to this since then
@theOperand <https://github.com/theOperand>
which version are you using?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#495 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6KUIIIM7CYTGR37DWSKULR3OVRXANCNFSM4OX44TQA>.
|
@theOperand Did you use one of the predefined date codes, or one you put together yourself? We added a date code very recently, I wonder if there was a bug in it? #477 |
Updating to 1.15.1 seems to have fixed the crashes for me at least. I was/am using a custom string. |
It happens on both custom string and regular formats with day of the week
for me. I haven't tried custom strings without day of the week. (partially
because the custom string format isn't entirely clear to me)
…On Wed, Jul 15, 2020, 01:27 robinpaulson ***@***.***> wrote:
@theOperand <https://github.com/theOperand> Did you use one of the
predefined date codes, or one you put together yourself? We added a date
code very recently, I wonder if there was a bug in it? #477
<#477>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#495 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6KUIIX6QPIGO3RBUULCADR3TSXHANCNFSM4OX44TQA>
.
|
@theOperand This does not fix the problem at all, however they may help you understand how "simple date format" works: They are written from a developer's format, so may be slightly arcane to the average person. In that case, this may be slightly more intelligible: http://www.java2s.com/Tutorial/Java/0040__Data-Type/SimpleDateFormat.htm |
The way we handle dates and times is weird, the hyphen in the middle causes problems for many unwary users (discussed many times). I recall we talked about using a built-in library rather than doing it ourselves. #287 (comment) |
@theOperand Where are you at with this, could you give us an update? Cheers |
I upgraded my LineageOS finally, which seems to have fixed the issue. Thanks for your help! |
@theOperand Did you reinstall forcastie from scratch, or take a backup and use that? |
I reinstalled everything from scratch. However, there is still a bug. The short day of the week formats (eg Sun, Mon, etc) don't cause a crash, but the full days of the week (Sunday, Monday, etc) do. |
I guess something was reset to a safe, default value.
This is interesting, it narrows the bug slightly. thanks for the feedback |
I am having this issue too on LineageOS with the latest version |
I get this bug on LineageOS 17.1. Reproduction is fairly simple on my device: Just go to settings, choose a date format with day of the week, e.g. "Thursday - 22:00", and go back to have the app crash.
I don't know how to provide logs, but will provide them if somebody tells me how :)
The text was updated successfully, but these errors were encountered: