Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused 'stream' feature flag causes build error in bhttp #71

Open
tanyav2 opened this issue Sep 25, 2024 · 0 comments
Open

Unused 'stream' feature flag causes build error in bhttp #71

tanyav2 opened this issue Sep 25, 2024 · 0 comments

Comments

@tanyav2
Copy link

tanyav2 commented Sep 25, 2024

The bhttp crate fails to build due to #[cfg(feature = "stream")] attribute in bhttp/src/err.rs, but the "stream" feature is not defined in bhttp/Cargo.toml.

Error:

error: unexpected `cfg` condition value: `stream`
  --> bhttp/src/err.rs:10:11
   |
10 |     #[cfg(feature = "stream")]
   |           ^^^^^^^^^^^^^^^^^^
   |
   = note: expected values for `feature` are: `bhttp`, `default`, `http`, `read-bhttp`, `read-http`, `url`, `write-bhttp`, and `write-http`
   = help: consider adding `stream` as a feature in `Cargo.toml`

Since this feature and the corresponding error ChunkTooLarge don't appear to be used, it can simply be fixed by removing these lines:

ohttp/bhttp/src/err.rs

Lines 9 to 11 in fd72888

#[error("a chunk of data of {0} bytes is too large")]
#[cfg(feature = "stream")]
ChunkTooLarge(u64),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant