Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recipe command icons do no load if there were errors loading the recipe #128

Closed
markfinal opened this issue Oct 8, 2023 · 0 comments
Closed

Recipe command icons do no load if there were errors loading the recipe #128

markfinal opened this issue Oct 8, 2023 · 0 comments
Assignees
@markfinal
Labels
bug Something isn't working
Milestone
v1.4.0

Comments

@markfinal
Copy link
Owner

The recipe window incorrectly looks like this

Screenshot 2023-10-08 at 21 11 33
@markfinal markfinal added the bug Something isn't working label Oct 8, 2023
@markfinal markfinal added this to the v1.4.0 milestone Oct 8, 2023
@markfinal markfinal self-assigned this Aug 15, 2024
markfinal added a commit that referenced this issue Aug 15, 2024
@markfinal
Fixes #128 Load toolbar icons even in failing to load recipe scenarios
f9c9a09 
The toolbar icons previously only loaded when a recipe loaded successfully
because it was tied to the shortcut creation that needed recipe attribute queries
to succeed.

In a recipe failure to load scenario, now try to load the toolbar icons properly
but the tooltips may be wrong.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markfinal markfinal

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.4.0
Development

No branches or pull requests
1 participant
@markfinal