-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more live examples #3209
Comments
I would like to collaborate on this issue, how can I create Live Examples? |
It'd be finding the areas within the docs that need them and forking off of jsfiddle.net/marionettejs/adhv48ky/ to make the examples. You can use your own url and we'll update them to the marionette account upon merge |
Should a live example be created for the 'Remove Region' and 'Adding Region' sections? |
I think the only place that an example would not improve the docs is if one already exists :-D |
Hi. @paulfalgout, what you think about this live example for the section 'Adding Region'? https://fiddle.jshell.net/charlyjazz/gze5ykov/16/ Do you think that is a good example? Or do we need an example more oriented to a real life scenario? |
Hmm I think a more real life scenario would be better. getTemplate() {
if (this.isAdmin) return AdminTemplate;
return Template;
},
onRender() {
if (this.isAdmin) {
this.addRegion('admin', '#admin-panel');
this.showChildView('admin', 'You are an admin!');
}
} |
Hi @paulfalgout, what you think about this live example for the section 'Adding Region'? |
Proposed changes The live example shows a practical scenario where regions are added to the view depending on the model Link to the issue: #3209
Proposed changes The live example shows a practical scenario where regions are added to the view depending on the model Link to the issue: marionettejs#3209
How can i view these live examples? In my here the site 'http://jsfiddle.net' can’t be reached. |
Hmm maybe you'd need a VPN? Not sure why jsfiddle wouldn't work |
We have a good start with making live examples, but we have to do more work to cover all docs by them. Here pages without live examples
The text was updated successfully, but these errors were encountered: