Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more live examples #3209

Open
3 tasks
denar90 opened this issue Sep 29, 2016 · 9 comments
Open
3 tasks

Add more live examples #3209

denar90 opened this issue Sep 29, 2016 · 9 comments
Labels

Comments

@denar90
Copy link
Member

denar90 commented Sep 29, 2016

We have a good start with making live examples, but we have to do more work to cover all docs by them. Here pages without live examples

@CharlyJazz
Copy link
Contributor

I would like to collaborate on this issue, how can I create Live Examples?

@paulfalgout
Copy link
Member

It'd be finding the areas within the docs that need them and forking off of jsfiddle.net/marionettejs/adhv48ky/ to make the examples. You can use your own url and we'll update them to the marionette account upon merge

@CharlyJazz
Copy link
Contributor

Should a live example be created for the 'Remove Region' and 'Adding Region' sections?

@paulfalgout
Copy link
Member

I think the only place that an example would not improve the docs is if one already exists :-D

@CharlyJazz
Copy link
Contributor

CharlyJazz commented Nov 13, 2017

Hi.

@paulfalgout, what you think about this live example for the section 'Adding Region'?

https://fiddle.jshell.net/charlyjazz/gze5ykov/16/

Do you think that is a good example? Or do we need an example more oriented to a real life scenario?

@paulfalgout
Copy link
Member

paulfalgout commented Nov 24, 2017

Hmm I think a more real life scenario would be better.
Perhaps something like:

getTemplate() {
  if (this.isAdmin) return AdminTemplate;

  return Template;
},
onRender() {
  if (this.isAdmin) {
   this.addRegion('admin', '#admin-panel');
   this.showChildView('admin', 'You are an admin!');
  }
}

@CharlyJazz
Copy link
Contributor

Hi @paulfalgout, what you think about this live example for the section 'Adding Region'?

http://jsfiddle.net/charlyjazz/gze5ykov/49/

paulfalgout pushed a commit that referenced this issue Jun 8, 2018
Proposed changes
The live example shows a practical scenario where regions are added to the view depending on the model

Link to the issue: #3209
blikblum pushed a commit to blikblum/backbone.marionette that referenced this issue Jun 30, 2018
Proposed changes
The live example shows a practical scenario where regions are added to the view depending on the model

Link to the issue: marionettejs#3209
@Purlicue
Copy link

How can i view these live examples? In my here the site 'http://jsfiddle.net' can’t be reached.

@paulfalgout
Copy link
Member

Hmm maybe you'd need a VPN? Not sure why jsfiddle wouldn't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants