fix: show hidden cells when markdown has no output #3320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Light2Dark
commented
Dec 31, 2024
| @@ -359,6 +361,17 @@ const CellEditorInternal = ({ | |||
| }; | |||
| }, [editorViewRef]); | |||
|
|
|||
| // Completely hide the editor & icons if it's markdown and hidden. If there is output, we show. | |||
| const showHideButton = | |||
There was a problem hiding this comment.
wonder if these should be memoized..
There was a problem hiding this comment.
These are just boolean operations, should be super cheap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Fixes #3317 . Should display hidden cells similar to pre-borderless-markdown era. Code may be a bit rough.
🔍 Description of Changes
📋 Checklist
📜 Reviewers
@akshayka OR @mscolnick