fix: partially instantiate notebooks when autorun on startup is disabled #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When autorun on startup is disabled, running a cell should only run its uninstantiated ancestors, and in particular it shouldn't run the uninstantiated descendants of uninstantiated ancestors.
This lets the notebook author incrementally run parts of their notebook on startup, even those that include UI elements, without making the entire notebook lazy.
Previously, running a cell would collect uninstantiated ancestors but also uninstantiated descendants, which would often be the entire notebook since uninstantiated ancestors often include imports.
This fix was implemented by keeping track of which execution requests are uninstantiated. This data structure is pruned as cells are run or deleted.