feat: add sqlglot to parse sql dataflow #3310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Light2Dark
changed the title
Light2Dark
commented
Dec 30, 2024
akshayka
reviewed
Dec 30, 2024
akshayka
reviewed
Dec 31, 2024
akshayka
reviewed
Dec 31, 2024
tests/_ast/test_sql_visitor.py
Outdated
Comment on lines
629
to
639
| @staticmethod | ||
| def test_find_sql_refs_with_recursive_cte() -> None: | ||
| sql = """ | ||
| WITH RECURSIVE cte AS ( | ||
| SELECT 1 AS n FROM table1 | ||
| UNION ALL | ||
| SELECT n + 1 FROM cte WHERE n < 10 | ||
| ) | ||
| SELECT * FROM cte; | ||
| """ | ||
| assert find_sql_refs(sql) == ["table1"] |
There was a problem hiding this comment.
If this is not yet supported, but you'd like to keep the test, you can decorate it with pytest.mark.xfail, as done here:
marimo/tests/_ast/test_sql_visitor.py
Line 569 in f8dc9f5
There was a problem hiding this comment.
it does work, I didn't see the need for it since we have tested nested cte's. Also noted on the dialect change. I may add back the has_duckdb dependency too.
thanks!!
akshayka
reviewed
Dec 31, 2024
Comment on lines
+731
to
+733
| def test_find_sql_refs_invalid_sql() -> None: | ||
| sql = "SELECT * FROM" | ||
| assert find_sql_refs(sql) == [] |
akshayka
approved these changes
Dec 31, 2024
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.10.10-dev1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Fixes #3103. Adds sqlglot as an optional dependency to handle complex sql refs parsing. Also supports DML statements (insert, update and delete).
🔍 Description of Changes
def find_sql_def()can also be modified to use sqlglot in the future, not included in this PR.📋 Checklist
📜 Reviewers
@akshayka OR @mscolnick