Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide SHELL Keyword from Dockerfile #84

Open
ghost opened this issue May 15, 2018 · 2 comments
Open

Provide SHELL Keyword from Dockerfile #84

ghost opened this issue May 15, 2018 · 2 comments

Comments

@ghost
Copy link

ghost commented May 15, 2018

It should be possible to change the executing shell, like the SHELL command from DOCKERFILE: https://docs.docker.com/engine/reference/builder/#shell

@marcus-drake
Copy link
Owner

Do you mean in some other way than what is supported now?
https://github.com/marcuslonnberg/sbt-docker/blob/master/src/main/scala/sbtdocker/DockerfileCommands.scala#L243

@ghost
Copy link
Author

ghost commented May 15, 2018

Yeah. If I'm right, https://github.com/marcuslonnberg/sbt-docker/blob/master/src/main/scala/sbtdocker/DockerfileCommands.scala#L243 would also be executed in /bin/sh, see: https://github.com/marcuslonnberg/sbt-docker/blob/8a6afaceb362542b7d64538d48699ff3c361591f/src/main/scala/sbtdocker/Instructions.scala#L133

The SHELL command from Dockerfile: https://docs.docker.com/engine/reference/builder/#shell could override the default shell, used by shell form commands like RUN.

An example command from my Dockerfile:
SHELL [ "/bin/bash", "-c" ]

I would like to create a pull request for the required changes to the files: "DockerfileCommands.scala" and "Instructions.scala" but actually I can't do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant