Missing JS dependency #239
Comments
|
Thanks for noticing this, fixed in #240 |
|
The lock file contains dependencies of dependencies. We don't need to list them in the package.json file. |
|
I hope I don't come across negatively combative but I disagree on this sentiment.
You can see this being true in that this spec is currently using 
|
|
To inspect the dependency tree one would usually run something like |
|
Hmm, I actually think you're proving my point further:
The problem is how many of these are actually used in production? Well to check we can filter: You can see the package is not listed anymore. One of the primary reasons for this the package not carrying over is because it comes for a dev-dependency: To be more precise, I'd argue even if Also, like I said before, because you don't have control over the versioning using this method, you are using an outdated package. If you're still not convinced, no worries feel free to close this issue. |
|
Thanks for pointing to this line @CraigglesO. Why are we using |
|
Ye I agree, the correct ES6+ syntax is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was reading up on the project of this project to a writeup of my own, how is
@mapbox/point-geometrya dependency, shows up in your lock file, but not a dependency? I'm assuming this is just a mistake or are you planning on removing it?https://github.com/search?q=repo%3Amaplibre%2Fmaplibre-tile-spec%20mapbox%2Fpoint-geometry&type=code
The text was updated successfully, but these errors were encountered: