-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MapView.getZoom() throwing TypeError in Alpha 25 & New Architecture #488
Comments
@KiwiKilian Any chance you can look into this per your wonderful recent changes? Let me know if you need more information. Other than this issue, I'm noticing my app now loads much faster with RN New Architecture, so I'm excited to get this working! |
Thanks for the report, we published the new arch support on alpha to get some more of these problems. Could you please paste in a reproduction? I think I understood the setup, but it would make it much to have a repro. From you description this is only about the new architecture. The changes between alpha 24 and 25 changed nothing about the new architecture – it only fixes the |
Thanks @brentforder, really appreciate you testing the new releases and reporting back.
This is really interesting to me. The RN New Arch Changes were only in 10.0.0-alpha.24. There were only two changes in 10.0.0-alpha.25, neither should have effected stability with RN New Arch. Any issues in alpha.24 should exist in alpha.25. 10.0.0.alpha.25 commits: It would be great if you could provide specifics as to why alpha.25 is more stable than alpha.24. |
Can confirm, the imperative Methods of If anyone has an idea, where to look, feel free to comment. I can't tell, when I have capacity to investigate, switching to new arch is currently not the main priority on my project. |
I'm struggling to get a proper minimal reproduction example together for this case. It appears that the maplibre-react-native example setup/dependencies are currently broken (even without RN New Architecture enabled), I've also never been able to get the "Getting Started" example working in the last ~10 months (MapView never mounts). My project's working example is quite complex. If you can get the official example app dependencies working, it should be easy to reproduce by:
|
Steps to Trigger Behavior
Expected Behavior
Actual Behavior
Screenshots (if applicable)
Environment
@maplibre/maplibre-react-native
Version: 10.0.0-alpha.25react-native
Version: 0.74.5expo
Version: 51.0.39Additional context
The text was updated successfully, but these errors were encountered: