Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type of _controlPositions property of the Map class #4649

Open
JabSYsEmb opened this issue Sep 3, 2024 · 1 comment · May be fixed by #4651
Open

type of _controlPositions property of the Map class #4649

JabSYsEmb opened this issue Sep 3, 2024 · 1 comment · May be fixed by #4651
Labels
bug Something isn't working good first issue Good for newcomers PR is more than welcomed Extra attention is needed

Comments

@JabSYsEmb
Copy link
Contributor

JabSYsEmb commented Sep 3, 2024 •
edited
Loading

I just noticed that the vscode intelljsense does not autocomplate for _controlPositions of Map class and found out it is due to that it is defined as Record<string, HTMLElement>, is that intentionally? Or typed incorrectly since _controlPositions cannot be positioned other than what the ControlPosition type is

maplibre-gl-js/src/ui/map.ts

Line 448 in 160b8f9

_controlPositions: Record<string, HTMLElement>;

I fix the type locally and get the nitelljsense working fine as in the following screenshot:

image
@HarelM
Copy link
Collaborator

HarelM commented Sep 3, 2024

Probably an incorrect type, feel free to open a PR.

@HarelM HarelM added bug Something isn't working PR is more than welcomed Extra attention is needed good first issue Good for newcomers labels Sep 3, 2024
JabSYsEmb added a commit to JabSYsEmb/maplibre-gl-js that referenced this issue Sep 3, 2024
@JabSYsEmb
fix maplibre#4649
956d331
@JabSYsEmb JabSYsEmb linked a pull request Sep 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers PR is more than welcomed Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

type fix JabSYsEmb/maplibre-gl-js
2 participants
@HarelM @JabSYsEmb