Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VISUAL] $Bumpmap2 doesn't render ( LightmappedGeneric / WorldVertexTransition ) #256

Open
WhiteRedDragons opened this issue Nov 30, 2023 · 2 comments
Labels
Bug Something isn't working

Comments

@WhiteRedDragons
Copy link

WhiteRedDragons commented Nov 30, 2023

Describe the bug

An issue in the cpp or fxc of the shader causes the second bumpmap to not appear.
Why? I don't know the shader is incredibly convoluted and I can't tell from a quick glance.


Additional context

Probably related to many other graphical issues that might have been reported in the past.
Cief reports this shader behaviour also happens on stock shaders

Cief also presents the contents of a VMT on which this issue has been seen
Seamless Scale is potentially not the cause of the issue as it happens without it as well.
$BaseTexture, $BaseTexture2, $BumpMap, $BumpMap2, $BlendmodulateTexture, $Seamless_Scale

@WhiteRedDragons WhiteRedDragons added the Bug Something isn't working label Nov 30, 2023
@WhiteRedDragons WhiteRedDragons changed the title [VISUAL] $Bumpmap bound to the wrong Sampler in LightmappedGeneric_dx9_helper.cpp [VISUAL] $Bumpmap2 bound to the wrong Sampler in LightmappedGeneric_dx9_helper.cpp Nov 30, 2023
@Petercov
Copy link

Petercov commented Dec 2, 2023

Lines 450 and 651 in LightmappedGeneric_dx9_helper.cpp are for the flashlight shader. SDK_lightmappedgeneric_flashlight_ps2x.fxc line 61 loads NormalMap2 from sampler 6. There was no issue here.

@WhiteRedDragons
Copy link
Author

You are correct, we realised this on the map labs discord, I will adjust the issue's name.
Now it baffles me as I cannot find a reason for $bumpmap2 to be broken then

@WhiteRedDragons WhiteRedDragons changed the title [VISUAL] $Bumpmap2 bound to the wrong Sampler in LightmappedGeneric_dx9_helper.cpp [VISUAL] $Bumpmap2 doesn't render ( LightmappedGeneric / WorldVertexTransition ) Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants