Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value processing and fallbacks #9

Open
ivankokan opened this issue Dec 5, 2018 · 0 comments
Open

Value processing and fallbacks #9

ivankokan opened this issue Dec 5, 2018 · 0 comments

Comments

@ivankokan
Copy link

ivankokan commented Dec 5, 2018

if (gp.value || gp.value === 0) {

var j = a[this._valueField] || 1;

this._min = a.min || 0;

I consider these lines very context-specific and not valid in general.
L305: Original value should be used, even if it is undefined or null.
L419: All 0 values will be considered as 1? Using non-processed original will do in general case.
L476: Not sure what to do here, remove || 0 from min-part or make something similar within max-part.

All those repeat in HeatmapImageryProvider.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant