Add git LFS support. #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please see #36 for details. |
|
Hey @pavelpokutnev, thanks for your contribution. Well appreciated. |
manoelcampos
requested changes
Oct 31, 2022
| @@ -9,6 +9,11 @@ if [[ "$INPUT_ADOC_FILE_EXT" != .* ]]; then | |||
| INPUT_ADOC_FILE_EXT=".$INPUT_ADOC_FILE_EXT"; | |||
| fi | |||
|
|
|||
| # Install git-lfs since it is not in Alpine base image. | |||
There was a problem hiding this comment.
I think the second option you mentioned in #36 is better, since we can provide a docker image with everything installed and reduce the code of entrypoint.sh.
The apk add openssh-client in that script could even be moved there too, but that is another issue.
asciidoctor-ghpages-action/entrypoint.sh
Line 13 in 7bcb8c6
|
Hey @pavelpokutnev |
|
I've just merged it. Thanks for the contribution. |
|
I've just moved software installation to the Dockerfile: Check 60643a4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #36
Adds the support for git repositories with LFS enabled. Since the Alpine base image doesn't include the git-lfs package, we do the installation of git-lfs in the entrypoint.sh.