Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easily browse or kill permalink to file with line number #365

Closed
amake opened this issue May 26, 2021 · 3 comments
Closed

Easily browse or kill permalink to file with line number #365

amake opened this issue May 26, 2021 · 3 comments
Labels
area: links duplicate This issue or pull request already exists enhancement New feature or request

Comments

@amake
Copy link

amake commented May 26, 2021

I often find myself wanting to send a GitHub permalink URL to someone. Often I want to point out a particular line or range of lines in a particular file at a particular revision, and to do this I have to go to GitHub, find the file (cumbersome), maybe find the exact commit (also cumbersome), select the range of lines, and choose "Copy Permalink" from the little menu thing.

It seems to me that Magit+Forge together should have enough information to generate the permalink from within Emacs. I am imagining something like forge-browse-dwim or forge-copy-url-at-point-as-kill being invocable on any line of a git-managed buffer. When a range is present the link would point to the full range of lines, like:

https://github.com/magit/forge/blob/551e51511e25505d14e05699a1707fd57e394a9a/Makefile#L8-L20

@pkryger
Copy link

pkryger commented May 26, 2021

I use git-link for that purposes.

@amake
Copy link
Author

amake commented May 26, 2021

Thanks! I'll check that out.

If this functionality is better left to other packages like git-link then feel free to close this ticket.

@tarsius tarsius added the enhancement New feature or request label Aug 8, 2021
@tarsius tarsius added the duplicate This issue or pull request already exists label Dec 9, 2023
@tarsius
Copy link
Member

tarsius commented Dec 9, 2023

Closing in favor of #91.

@tarsius tarsius closed this as completed Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: links duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants