Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[component] 20+ buttons! #129

Open
dillionverma opened this issue Jun 5, 2024 · 10 comments
Open

[component] 20+ buttons! #129

dillionverma opened this issue Jun 5, 2024 · 10 comments
Assignees

Comments

@dillionverma
Copy link
Collaborator

dillionverma commented Jun 5, 2024

Talked with a good friend Alexandru and he gave us permission to integrate his components into Magic UI 🎉🥳🎁

https://snippets.alexandru.so

The original designs come from Emil who is also an incredibly talented design engineer and made these MIT license and open sourced

https://github.com/emilkowalski/ui-snippets

There are a lot of goodies here!

We need to remake these using React + TailwindCSS + typescript to integrate them into Magic UI 🪄

2 options on how to integrate:

  1. We make separate magicui components for each one
  2. We make a special "buttons" page which contains all of these as copy paste buttons

Having all buttons on 1 page makes sense to me but requires a bit of engineering work to figure out the best user experience.

Any suggestions?

@pilladipesh33
Copy link
Contributor

We can do it like https://bg.ibelick.com/ this where once pressed shows in main section and there functionality I think that will do it

@dillionverma
Copy link
Collaborator Author

Ya I agree one page is better

Looks like we need a PR with a new page structure which showcases all the buttons or elements on one page

Not sure how best to do it yet given the current codebase

Will have to think about it, also open to suggestions or ideas

@pilladipesh33
Copy link
Contributor

Let me think more...😤

@pilladipesh33
Copy link
Contributor

Can I add more button design in this link some are just basic animation so instead of that we should add unique what you say @dillionverma. By the way started working on this may as well assigned it me

@dillionverma
Copy link
Collaborator Author

yeah feel free to add more!

I liked this basic set of buttons as well though - they are pretty clean and minimal. Could be used in a lot of projects in interesting ways.

assigned to you :)

@pilladipesh33
Copy link
Contributor

pilladipesh33 commented Jun 9, 2024

@dillionverma components are ready what have you thought on showcasing them should just add buttons in <ol> and comment out it's number in the code or should I add copy code to clipboard feature.

@dillionverma
Copy link
Collaborator Author

hmm good question - do you have a screenshot / image / PR of what you had in mind? would help to visualize it @pilladipesh33

@pilladipesh33
Copy link
Contributor

Ok let me look into it

@pilladipesh33
Copy link
Contributor

@dillionverma created a PR, let me know if I have to add anything else

@pilladipesh33
Copy link
Contributor

Hey @dillionverma it's been 2 week didn't got any update ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants