Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/core is mapped as folders not as files #174

Open
flancer64 opened this issue Jan 3, 2015 · 2 comments
Open

magento/core is mapped as folders not as files #174

flancer64 opened this issue Jan 3, 2015 · 2 comments

Comments

@flancer64
Copy link

Hello, guys.

I have created project with the following composer.json:

{
  ...
  "require": {
    "magento-hackathon/magento-composer-installer": "*",
    "magento-hackathon/composer-command-integrator": "*@dev",
    "composer/composer": "*@alpha",
    "magento/core": "1.9.1.0",
    "connect20/nmmlm_log": "*"
  },
  "repositories": [
    {
      "type": "composer",
      "url": "http://packages.firegento.com"
    }
  ],
  "extra": {
    "magento-root-dir": "mage",
    "magento-deploystrategy": "symlink",
    "auto-append-gitignore": true
  }
}

when I run composer:

composer install

I have folder mapping for magento/core module in ./mage/.gitignore file:

#magento/core
/app
/downloader
/errors
/includes
/js
/lib
/media
/pkginfo
/shell
/skin
/var
/.htaccess
/api.php
/cron.php
/cron.sh
/favicon.ico
/get.php
/index.php
/install.php
/mage
#connect20/nmmlm_log
/app/code/community/Nmmlm/Log/Logger.php
/app/code/community/Nmmlm/Log/Util.php
/app/code/community/Nmmlm/Log/etc/config.xml
...

I need file level mapping in ./mage/.gitignore for my project to get git available for theme and non-composer Magento modules. What configure parameter I should use to get file level mapping instead of folder level mapping for magento/core?

Thanks,

Alex.

@AydinHassan
Copy link
Member

AFAIK this is not supported. Shameless plug but I have package to manage the core which should do what you want it to do.

@flancer64
Copy link
Author

Hello, Aydin.

Thanks for your solution. I will try to use it in our projects.

I have created a project - https://github.com/praxigento/z_mage_composer_prj_01_full/tree/without_mage_gitignore and when I deploy this project using Magento Composer file ./mage/.gitignore contains almost all mage/core entries. These entries are not in the mage/.gitignore:

$ git status
On branch master
Your branch is up-to-date with 'origin/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)

        mage/.gitignore
        mage/app/.htaccess
        mage/app/Mage.php
        mage/app/code/community/Nmmlm/
        mage/app/etc/config.xml
        mage/app/etc/local.xml.additional
        mage/app/etc/local.xml.template
        mage/app/etc/modules/Cm_RedisSession.xml
        mage/app/etc/modules/Mage_All.xml
        mage/app/etc/modules/Mage_Api.xml
        mage/app/etc/modules/Mage_Api2.xml
        mage/app/etc/modules/Mage_Authorizenet.xml
        mage/app/etc/modules/Mage_Bundle.xml
        mage/app/etc/modules/Mage_Captcha.xml
        mage/app/etc/modules/Mage_Centinel.xml
        mage/app/etc/modules/Mage_Compiler.xml
        mage/app/etc/modules/Mage_ConfigurableSwatches.xml
        mage/app/etc/modules/Mage_Connect.xml
        mage/app/etc/modules/Mage_CurrencySymbol.xml
        mage/app/etc/modules/Mage_Downloadable.xml
        mage/app/etc/modules/Mage_ImportExport.xml
        mage/app/etc/modules/Mage_Oauth.xml
        mage/app/etc/modules/Mage_PageCache.xml
        mage/app/etc/modules/Mage_Persistent.xml
        mage/app/etc/modules/Mage_Weee.xml
        mage/app/etc/modules/Mage_Widget.xml
        mage/app/etc/modules/Mage_XmlConnect.xml
        mage/app/etc/modules/Nmmlm_Log.xml
        mage/app/etc/modules/Phoenix_Moneybookers.xml
        mage/app/etc/nmmlm/
        mage/app/locale/
        mage/js/blank.html
        mage/js/index.php
        mage/js/spacer.gif
        mage/lib/
        mage/media/.htaccess


It took 6.30 seconds to enumerate untracked files. 'status -uno'
may speed it up, but you have to be careful not to forget to add
new files yourself (see 'git help status').
nothing added to commit but untracked files present (use "git add" to track)

File mage/.gitignore generated by composer does not contain markers

#magento/core
#connect20/nmmlm_log

and Nmmlm_Log entries look like

/./app/code/community/Nmmlm/Log/Logger.php
/./app/code/community/Nmmlm/Log/Util.php
/./app/code/community/Nmmlm/Log/etc/config.xml
...

not like

/app/code/community/Nmmlm/Log/Logger.php
/app/code/community/Nmmlm/Log/Util.php
/app/code/community/Nmmlm/Log/etc/config.xml

It is not critical for me, I hope, just for note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants