Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Cache On Theme Directory Rename #72

Open
sprankhub opened this issue Mar 12, 2020 · 2 comments
Open

Clean Cache On Theme Directory Rename #72

sprankhub opened this issue Mar 12, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@sprankhub
Copy link

I have a theme under src/Namespace/Themename. ./src/*/* is defined as a local composer repository. When I rename the directory src/Namespace/Themename/Magento_Catalog to src/Namespace/Themename/Magento_Catalog2 (to quickly check if my customisations broke something), the cache is not cleared. I guess it makes sense to clear it in this case as well?

@Vinai
Copy link
Contributor

Vinai commented Mar 13, 2020

Thanks for opening the issue!

Currently I don't think the watcher registeres renaming of theme directories, only files within that directory, but I will check.
In the meanwhile, maybe there is a similarly easy way to temporarily disable a theme, e.g. by renaming the registration.php file or such? Just a thought.

@Vinai Vinai added the enhancement New feature or request label Mar 13, 2020
@sprankhub
Copy link
Author

Thanks! Not sure what happens when the theme is configured, but not present anymore. I would expect an error. Anyway, this is also helpful during refactoring.

If you check that, it may make sense to check if renaming of extension directories is currently detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants