Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for error might have been needed #805

Open
irwir opened this issue Apr 19, 2023 · 1 comment
Open

Check for error might have been needed #805

irwir opened this issue Apr 19, 2023 · 1 comment

Comments

@irwir
Copy link

irwir commented Apr 19, 2023

Comparing two code blocks, starting here

if (zi->ci.stream.avail_out == 0)

and here
if (zi->ci.stream.avail_out == 0)

In the first case err was assigned and checked after the conditional statement.
In the second case it was ignored and overwritten (as pointed out by cppcheck).
Either the assignment to err is unnecessary, or error condition should be checked.

@irwir
Copy link
Author

irwir commented Aug 15, 2023

@gvollant, could you please help with this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant