Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Weblate into monerujo + remove fuzzy translations #966

Closed
wants to merge 32 commits into from

Conversation

lucasmz-dev
Copy link
Contributor

@lucasmz-dev lucasmz-dev commented Nov 4, 2024

https://hosted.weblate.org/projects/monerujo

Being dealt with in a separate branch that we can test everything as safely as possible.
After this is merged, it will be changed to use an automatic GitHub PR + automatic webhooks so that pull is automatic.

Let's see how Weblate behaves with monerujo strings.

Contains #960
Closes #958

Removes strings from translations, where the string was translated and the source string was later changed, but the translation never invalidated

May potentially not include all strings, the process to find them was to look into Git Blame and see weird dates and what was changed.
We don't need this, we ignore the MissingTranslation flag.
It also means it fallbacks to another variant if available, instead of always being english.
Quick find and replace
Currently translated at 100.0% (368 of 368 strings)

Translation: monerujo/App - Main
Translate-URL: https://hosted.weblate.org/projects/monerujo/app-main/pt_BR/
Currently translated at 100.0% (20 of 20 strings)

Translation: monerujo/App - Help
Translate-URL: https://hosted.weblate.org/projects/monerujo/app-help/pt_BR/
@lucasmz-dev lucasmz-dev marked this pull request as ready for review November 5, 2024 04:45
@lucasmz-dev
Copy link
Contributor Author

lucasmz-dev commented Nov 5, 2024

@m2049r please do not modify source strings from now on! it's fine if you do but don't change translations! It's better to remove them, maintenance wise. It's IMO easier for us to translate things again than to have to go through every string just to see that something might be wrong, and it becomes confusing because sometimes things can be well... adaptations. If you can get those basic changes that disable linting for MissingTranslation, that would be nice.

I still need to figure out how to build to see how things are looking, but it seems OK ATM. These CDATA strings are kind of bad, they show up in a very raw format in Weblate and so the translator still needs to deal with things like \s, weird things like that...

@lucasmz-dev lucasmz-dev changed the title Weblate Integrate Weblate into monerujo Nov 5, 2024
Updated by "Cleanup translation files" add-on in Weblate.

Translation: monerujo/App - Main
Translate-URL: https://hosted.weblate.org/projects/monerujo/app-main/
@lucasmz-dev
Copy link
Contributor Author

lucasmz-dev commented Nov 7, 2024

Um... weblate deleted the monerujo project 😀
i am very confused
sending them an email

@lucasmz-dev
Copy link
Contributor Author

@m2049r they restored it ^^
might've been my fault I might have accidentally clicked to ask for approval before the time 😬
you might need to accept an invitation

m2049r and others added 4 commits November 8, 2024 23:18
Currently translated at 80.0% (4 of 5 strings)

Translation: monerujo/App - About
Translate-URL: https://hosted.weblate.org/projects/monerujo/app-about/es/
Currently translated at 80.0% (4 of 5 strings)

Translation: monerujo/App - About
Translate-URL: https://hosted.weblate.org/projects/monerujo/app-about/es/
Currently translated at 99.7% (371 of 372 strings)

Translation: monerujo/App - Main
Translate-URL: https://hosted.weblate.org/projects/monerujo/app-main/pt_BR/
@lucasmz-dev
Copy link
Contributor Author

I went over all strings I didn't do, and flagged anything that seemed weird with a comment, will be looking into it in Git history soon to see if it was just an adaptation or if it was a changed string or something
e.g. Node -> Network

lucasmz-dev and others added 6 commits November 8, 2024 21:14
also changes the link with an engage link instead of a regular project link
Currently translated at 100.0% (5 of 5 strings)

Translation: monerujo/App - About
Translate-URL: https://hosted.weblate.org/projects/monerujo/app-about/es/
Currently translated at 100.0% (20 of 20 strings)

Translation: monerujo/App - Help
Translate-URL: https://hosted.weblate.org/projects/monerujo/app-help/es/
Currently translated at 99.7% (371 of 372 strings)

Translation: monerujo/App - Main
Translate-URL: https://hosted.weblate.org/projects/monerujo/app-main/pt_BR/
Currently translated at 99.7% (371 of 372 strings)

Translation: monerujo/App - Main
Translate-URL: https://hosted.weblate.org/projects/monerujo/app-main/es/
lucasmz-dev and others added 2 commits November 12, 2024 12:00
Currently translated at 100.0% (372 of 372 strings)

Translation: monerujo/App - Main
Translate-URL: https://hosted.weblate.org/projects/monerujo/app-main/pt_BR/
Currently translated at 100.0% (372 of 372 strings)

Translation: monerujo/App - Main
Translate-URL: https://hosted.weblate.org/projects/monerujo/app-main/es/
@lucasmz-dev
Copy link
Contributor Author

Hey, @m2049r
Could you build a debug build for this branch? It'd help a lot!

…nt globally

AKA strings that were changed on source but not removed from translations, all that
Currently translated at 100.0% (372 of 372 strings)

Translation: monerujo/App - Main
Translate-URL: https://hosted.weblate.org/projects/monerujo/app-main/pt_BR/
@lucasmz-dev
Copy link
Contributor Author

lucasmz-dev commented Nov 25, 2024

I think this might be ready to merge! Need to check if everything seems alright, but after that, and being merged, we can point things properly to this repository and after that ask for libre hosting.

EDIT: actually I need to merge the other translations... let's see

lucasmz-dev and others added 2 commits November 24, 2024 23:33
Squashed commit of the following:

commit 65fd465
Author: cardpuncher <[email protected]>
Date:   Sun Oct 6 10:51:31 2024 +0300

    Update help.xml

commit 6d5190f
Author: cardpuncher <[email protected]>
Date:   Sun Oct 6 10:38:38 2024 +0300

    All errors should have been cleared now

    Crossing fingers, click & pray.

commit 0ae3647
Author: cardpuncher <[email protected]>
Date:   Sun Oct 6 10:32:00 2024 +0300

    Still on it

commit f8346a9
Author: cardpuncher <[email protected]>
Date:   Sun Oct 6 10:29:52 2024 +0300

    Error hunting goes on

    Hopefully there aren't many left.

commit 08bf318
Author: cardpuncher <[email protected]>
Date:   Sun Oct 6 10:11:02 2024 +0300

    Squash some syntax errors, there are others

commit df9ea45
Author: cardpuncher <[email protected]>
Date:   Sun Oct 6 09:41:33 2024 +0300

    Update French translations

    and fix a few typos in the process.

commit 3ea605f
Author: cardpuncher <[email protected]>
Date:   Sat Oct 5 23:16:56 2024 +0300

    Complete Turkish translation

commit f04e3dd
Merge: abae1f3 3e56d5a
Author: cardpuncher <[email protected]>
Date:   Sat Oct 5 23:15:38 2024 +0300

    Merge branch 'm2049r:master' into master

commit abae1f3
Author: cardpuncher <[email protected]>
Date:   Fri Sep 20 12:36:27 2024 +0300

    Yet another copy & paste error... :/

commit b1118ae
Author: cardpuncher <[email protected]>
Date:   Fri Sep 20 12:29:17 2024 +0300

    Fix a dumb copy & paste error

    Hopefully this will silence the error.

commit 0ae7c8c
Author: cardpuncher <[email protected]>
Date:   Fri Sep 20 12:18:10 2024 +0300

    Update French & Turkish translations

    Mainly for the Sidekick part, also added a few missing strings to the French translation and reverted to use the original "Ledger" word in the Turkish one.

Co-authored-by: cardpuncher <[email protected]>
@@ -109,50 +109,6 @@
Aquest és el bloc de la cadena de Monero on la vostra transacció ha estat inclosa.
]]></string>

<string name="help_send"><![CDATA[
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i still don't think we should be losing good translations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean I can just go over and just cherry-pick the barebones, but the reason why I went over with this is that we can't for sure know for every language that they are in fact "good translations"
Changing wording can mean very different things in different languages and affect what gender's used, word position, stuff like that, that's the reason I went over like this, the people who want to make these translations work out will and with Weblate any changes in the future can be easily fixed by translators and not go unnoticed

If you're fine with that, I'll do it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weblate has a pretty nice graceful way to deal with "fuzzy" translations, they're marked as needing for editing and show the differences done in the source string, but it doesn't do anything about old commits before integration with it, that's basically what I tried to achieve here, in the end it'd be less work in the end to you and the translators IMO
A lot of translators aren't gonna have the energy/time/want to go through everything, and just wanna be able to translate right off the bat, I am like that for certain apps, especially when they have a messy situation anyway

RN my suggestion is: check #975 and I'll rebase this and then you can see if you want this, so that we can get weblate hosting at least since we'll need those to get things working at a basic level

@m2049r
Copy link
Owner

m2049r commented Nov 26, 2024

if you want, i can look through all translations and remove the non-translated stuff. so this PR would be the barebones of weblate enablement?
not sure what's best

@lucasmz-dev lucasmz-dev changed the title Integrate Weblate into monerujo Integrate Weblate into monerujo + remove outdated strings Nov 27, 2024
Currently translated at 100.0% (372 of 372 strings)

Translation: Monerujo/App - Main
Translate-URL: https://hosted.weblate.org/projects/monerujo/app-main/es/
@lucasmz-dev lucasmz-dev mentioned this pull request Nov 30, 2024
@lucasmz-dev lucasmz-dev changed the title Integrate Weblate into monerujo + remove outdated strings Integrate Weblate into monerujo + remove fuzzy translations Dec 2, 2024
Already set these as read-only in Weblate but better to do this in the source code
Currently translated at 100.0% (372 of 372 strings)

Translation: monerujo/App - Main
Translate-URL: https://hosted.weblate.org/projects/monerujo/app-main/pt_BR/
@lucasmz-dev lucasmz-dev closed this Dec 7, 2024
@lucasmz-dev lucasmz-dev deleted the weblate branch December 12, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weblate as a translation platform
3 participants