This repository has been archived by the owner on Oct 5, 2022. It is now read-only.
Add a flag --command_labels that #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labels with the nagios command, or if the metrics are named with the
nagios command.
--command_labels=false (the default)
nagios_paphosting_check_ssh_exec_time{hostname="absynth.ipng.nl", service="sshd:22"} 0.093268
--command_labels=true
nagios_command_exec_time{hostname="absynth.ipng.nl", command="paphosting_check_ssh", service="sshd:22"} 0.093268
See discussion in:
m-lab#13
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag determines if the metrics contain labels with the nagios command, or if the metrics are named with the
nagios command.
--command_labels=false (the default)
nagios_paphosting_check_ssh_exec_time{hostname="absynth.ipng.nl", service="sshd:22"} 0.093268
--command_labels=true
nagios_command_exec_time{hostname="absynth.ipng.nl", command="paphosting_check_ssh", service="sshd:22"} 0.093268
Justification for this PR is in #13
Code works but are missing tests. Per discussion with Stephen, I'm a bit strapped for time so I won't be able to add tests any time soon. I can however polish this PR up if need be. Thanks for your consideration and working on plugging Nagios into Prometheus!