Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last ndt7 ServerMeasurement snapshot not taken at end of test #380

Open
stephen-soltesz opened this issue Feb 8, 2023 · 0 comments
Open

Last ndt7 ServerMeasurement snapshot not taken at end of test #380

stephen-soltesz opened this issue Feb 8, 2023 · 0 comments

Comments

@stephen-soltesz
Copy link
Contributor

The ndt7 archival format does not include the average rate observed by the client or server. So, the data pipeline uses the last observed tcpinfo snapshot to calculate the average rates. https://github.com/m-lab/etl/blob/main/parser/ndt7_result.go#L165-L181

However, the ndt7 server does not guarantee when these snapshots are observed and recorded in the ServerMeasurements. This means that the archived last snapshot may not occur near the actual close of the connection. https://github.com/m-lab/ndt-server/blob/main/ndt7/download/sender/sender.go#L72-L86

Ideally, when the server is shutting down the connection it would take and record one final snapshot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stephen-soltesz