Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nightly docker image #1590

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Fix nightly docker image #1590

merged 3 commits into from
Dec 18, 2024
+34 −23

Conversation

trask
Copy link
Contributor

@trask trask commented Dec 17, 2024 •
edited
Loading

Resolves #1582

@mre any thoughts on how to test this?

@trask trask marked this pull request as ready for review December 17, 2024 20:58
mre added 2 commits December 18, 2024 01:05
@mre
fix path to release binary
b45f78c
@mre
Update Dockerfile to support both latest and nightly
01c38aa 
Also supports dedicated release names like `lychee-v0.17.0` now.

It can be built locally with

```
docker build --build-arg LYCHEE_VERSION=latest -f Dockerfile-CI.Dockerfile .
```
@mre
Copy link
Member

mre commented Dec 18, 2024

Ah, I forgot that latest is a special case; the URL is different.

I think I fixed it with my latest push.

@mre any thoughts on how to test this?

The easiest way is to run it locally:

docker build --build-arg LYCHEE_VERSION=latest -f Dockerfile-CI.Dockerfile .

The GitHub Actions workflow could be tested with act, but it doesn't cover all the edge-cases.

We can trigger the workflow to see what happens, but apart from that, our best bet is to just give it a shot by merging it. 🤷‍♀️

@mre
Copy link
Member

mre commented Dec 18, 2024

Tests are green and it works locally. I can't trigger the pipeline since it's on your fork, and you probably won't have any lychee releases on there.
From my side, we can merge this if you give me the green light. 😃

@trask
Copy link
Contributor Author

trask commented Dec 18, 2024

thanks!

I pulled your changes and tested locally, and with LYCHEE_VERSION=nightly I get the new --root-dir option and with LYCHEE_VERSION=latest I don't!

🚢

@mre mre merged commit 76dbd84 into lycheeverse:master Dec 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mre mre mre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker image lycheeverse/lychee:master doesn't contain latest from master branch?
2 participants
@trask @mre